1. [03:13] * _Zaphod_ ([email protected]) has joined #trinity
  2. [03:14] <_Zaphod_> okay, waht fiends of item_template are wdb and what aren't? it's clear that scriptname is not, but i'm not sure about the others.
  3. [03:14] <%Nayd> there's a wdb fields page on the wiki
  4. [03:14] * LimitServ sets mode: +l 80
  5. [03:14] <_Zaphod_> there's a certain Jewellcrafting recipe for cutting black diamonds...
  6. [03:14] * Kinzcool is now known as kinzcool
  7. [03:15] <_Zaphod_> ani'm notsure i the correct way to make it work is to script the Prismatic Black Diamond, or to put a special case in core for the recipe.
  8. [03:15] <%Nayd> script the spell, not the item
  9. [03:16] <_Zaphod_> but the spell has no script effect.
  10. [03:16] <%Nayd> spell id?
  11. [03:16] <_Zaphod_> it creates a prismatic black diamond.
  12. [03:17] <_Zaphod_> http://www.wowhead.com/spell=62941
  13. [03:17] <_Zaphod_> but instead of that item, you get a different cut gem instead.
  14. [03:18] <_Zaphod_> so it seems that the item needs to expire instantly, and be replaced by the itemscript.
  15. [03:18] <_Zaphod_> but if duration i a wdb field...
  16. [03:19] <_Zaphod_> you see the confusion, now?
  17. [03:20] * Sdyess ([email protected]) has joined #trinity
  18. [03:20] <%Nayd> spell_loot_template
  19. [03:20] <%Nayd> table
  20. [03:21] <%Nayd> https://github.com/TrinityCore/TrinityCore/blob/master/src/server/game/Spells/SpellEffects.cpp#L1729
  21. [03:21] <%Nayd> // remove reagent
  22. [03:21] <%Nayd> // create some random items
  23. [03:21] <%Nayd> that's what you are looking for
  24. [03:22] <%Nayd> now, please, add the loot info to table spell_loot_template
  25. [03:22] <%Nayd> entry 62941
  26. [03:22] <%Nayd> and post the fix on the tracker
  27. [03:27] <+KPsN04> WPP: Nay master * re64f073 / WowPacketParser/Parsing/Handler.cs : Fix a compiler error (Delegate.GetMethodInfo() only exists in C# 4.5, not C# 4.0) - http://git.io/g5hhuQ
  28. [03:29] <_Zaphod_> well now i need to get some accurate loot info. :)
  29. [03:29] <%Nayd> I'de follow this
  30. [03:29] <%Nayd> http://www.wowhead.com/item=45054#comments:id=1695380
  31. [03:31] <%Nayd> 23%, 23%, 23%, 23%, 8% ?
  32. [03:31] * ScymeX ([email protected]) Quit (Ping timeout: 240 seconds)
  33. [03:31] <%Nayd> oh wait, there's yellow too
  34. [03:31] <%Nayd> 20%, 20%, 20%, 20%, 5%, 5%
  35. [03:31] * ScymeX ([email protected]) has joined #trinity
  36. [03:32] <%Nayd> and I don't know how to count
  37. [03:44] <_Zaphod_> ERROR spell_loot_template entry 62941 isn't spell id (random item crating) and thus useless.
  38. [03:44] <%Nayd> lies!
  39. [03:44] <_Zaphod_> that's what my core told me.
  40. [03:44] <%Nayd> (by the core)
  41. [03:44] <%Nayd> ye
  42. [03:45] <_Zaphod_> so it will work anyway? :)
  43. [03:45] <%Nayd> probably not
  44. [03:45] <%Nayd> you are using Trinity?
  45. [03:46] <_Zaphod_> yeah.
  46. [03:46] <%Nayd> I can't find the error message
  47. [03:46] <_Zaphod_> mayeb we need an override?
  48. [03:46] <_Zaphod_> hmm. lemme find it.
  49. [03:47] <%Nayd> spell id (random item creating)
  50. [03:47] <%Nayd> crating != creating :)
  51. [03:48] <_Zaphod_> so commenting out line 52 is a fix?
  52. [03:48] <%Nayd> not a proper fix
  53. [03:49] <_Zaphod_> no thatowuldt' work..
  54. [03:49] * Svannon ([email protected]) Quit (Read error: Connection reset by peer)
  55. [03:49] * Svannon ([email protected]) has joined #trinity
  56. [03:49] <%Nayd> problem is in
  57. [03:49] <%Nayd> bool SpellInfo::IsLootCrafting() const
  58. [03:49] <%Nayd> {
  59. [03:49] <%Nayd> return (Effects[0].Effect == SPELL_EFFECT_CREATE_RANDOM_ITEM ||
  60. [03:49] <%Nayd> (Effects[0].Effect == SPELL_EFFECT_CREATE_ITEM_2 &&
  61. [03:49] <%Nayd> (TotemCategory[0] != 0 || Effects[0].ItemType == 0)));
  62. [03:49] <%Nayd> }
  63. [03:50] <%Nayd> Effects[0].ItemType == 0
  64. [03:50] <%Nayd> fails on that
  65. [03:50] <%Nayd> it's not zero, it's the pristine black diamond
  66. [03:50] <%Nayd> which makes perfect sense
  67. [03:53] <_Zaphod_> yet you never recieve that diamond.
  68. [03:53] <%Nayd> https://github.com/TrinityCore/TrinityCore/commit/45e750148a256333b49dae7b2725eb815ba4089d
  69. [03:53] <%Nayd> old shit...
  70. [03:54] <_Zaphod_> and there can only be one validation contition like that, huh?
  71. [03:59] <_Zaphod_> okay. problemmust be in LoadLootTemplates_Spell() right?
  72. [03:59] <%Nayd> yeah, because that also calls IsLootCrafting
  73. [04:00] <%Nayd> this code wasn't changed since mangos times
  74. [04:00] <%Nayd> and I just checked, they still do the same exact checks
  75. [04:02] <%Nayd> spell 59502 Darkmoon Card
  76. [04:02] <%Nayd> does the exact same thing
  77. [04:02] <%Nayd> and has loot in spell_loot_template
  78. [04:02] <%Nayd> how doesn't that error?
  79. [04:02] <_Zaphod_> it doesn't.
  80. [04:02] <%Nayd> yes, why?
  81. [04:03] <%Nayd> what am I missing...
  82. [04:04] <_Zaphod_> wait a minute.. i'm gonna check something..
  83. [04:05] * lordchip ([email protected]) Quit (Read error: Connection reset by peer)
  84. [04:05] <_Zaphod_> nope, that uses groulid 1 as well, so that's not it.
  85. [04:06] <_Zaphod_> time to check the dbc.
  86. [04:07] <%Nayd> darkmoon spell
  87. [04:07] <%Nayd> http://paste2.org/p/2816296
  88. [04:07] <%Nayd> prismatic
  89. [04:07] <%Nayd> http://paste2.org/p/2816298
  90. [04:07] <%Nayd> same exact thing, EffectMiscValueA and EffectItemType change
  91. [04:09] <%Nayd> silly SpellWork
  92. [04:09] <%Nayd> it's incomplete
  93. [04:10] <%Nayd> Darkmoon has TotemCategory1 = 121
  94. [04:10] <%Nayd> Prismatic has TotemCategory1 = 0
  95. [04:10] <%Nayd> [03:49] <%Nayd> (TotemCategory[0] != 0 || Effects[0].ItemType == 0)));
  96. [04:10] <%Nayd> condition will be true for 1st spell
  97. [04:10] <%Nayd> however
  98. [04:10] <%Nayd> Darkmoon has Totem1 = 0
  99. [04:11] <%Nayd> Prismatic has Totem1 = 20824
  100. [04:11] * hexa ([email protected]) has joined #trinity
  101. [04:14] * hexa- ([email protected]) Quit (Ping timeout: 240 seconds)
  102. [04:15] <_Zaphod_> so fix is ((TotemCategory[0] != 0) || (Totem[0] != 0) || Effects[0].ItemType == 0)));
  103. [04:15] <%Nayd> that's what I am thinking
  104. [04:16] <_Zaphod_> testing.
  105. [04:17] <%Nayd> wait a second..
  106. [04:17] <%Nayd> there are spells to create the items
  107. [04:18] <_Zaphod_> ye sthere are.
  108. [04:18] <_Zaphod_> the standard crating spells
  109. [04:18] <%Nayd> they all have the same Totem1
  110. [04:18] <_Zaphod_> but that's not relevant.
  111. [04:19] <%Nayd> 72 spells
  112. [04:19] <%Nayd> what does Totem1 mean?
  113. [04:19] <_Zaphod_> all i care is if this bypasses the DB error.
  114. [04:19] <%Nayd> siigh
  115. [04:19] <%Nayd> wrong mindset is wrong
  116. [04:23] <_Zaphod_> what about those 72 spells?
  117. [04:23] <_Zaphod_> as i said, the gems that the prismatic diamond turns into are also normally craftable.
  118. [04:24] <_Zaphod_> it turns into a level 60 red, blue or yellow gem.
  119. [04:24] <%Nayd> you will likely break those 72 spells if you do
  120. [04:24] <%Nayd> [04:15] <_Zaphod_> so fix is ((TotemCategory[0] != 0) || (Totem[0] != 0) || Effects[0].ItemType == 0)));
  121. [04:24] <_Zaphod_> of green rarity.
  122. [04:25] <_Zaphod_> hmm.
  123. [04:25] * eddyb ([email protected]) has joined #trinity
  124. [04:26] <%Nayd> mind fuck..
  125. [04:26] <_Zaphod_> so those 72 spells have totemcagegory[0] of 0, and totem[0]of not zero?
  126. [04:27] <%Nayd> exactly
  127. [04:27] <%Nayd> and same effect
  128. [04:27] <%Nayd> 157
  129. [04:27] <_Zaphod_> so we need a bitmask on totem[0]?
  130. [04:28] <%Nayd> it's not a flag
  131. [04:29] <_Zaphod_> well clearly it's not a spell.
  132. [04:31] <_Zaphod_> or an npc, or an item, oragameobject.
  133. [04:31] <%Nayd> what ya talkin about?
  134. [04:31] <_Zaphod_> i just crosschecked 20824
  135. [04:31] <_Zaphod_> Prismatic has Totem1 = 20824
  136. [04:31] <%Nayd> oh those
  137. [04:31] <%Nayd> I don't know either
  138. [04:31] <%Nayd> internal blizz ids
  139. [04:31] <_Zaphod_> so trying to figure out what's so special about that number.
  140. [04:31] <%Nayd> same for MiscValue
  141. [04:32] <_Zaphod_> so what's miscvalue for prismatic and darkmoon?
  142. [04:33] <%Nayd> 26876
  143. [04:33] <%Nayd> 26663
  144. [04:33] <_Zaphod_> and for those other 72 item creation spells?
  145. [04:33] <%Nayd> different values
  146. [04:33] <%Nayd> around 20k-ish
  147. [04:34] <_Zaphod_> anything else have totem1=20824 at all?
  148. [04:34] <%Nayd> all of the 72 spells
  149. [04:34] <%Nayd> + Prismatic
  150. [04:34] <_Zaphod_> link me one of the spells. :)
  151. [04:35] <%Nayd> 53831
  152. [04:36] <_Zaphod_> so correct to script in the item itself after all?!?!
  153. [04:36] <%Nayd> nein
  154. [04:36] <%Nayd> http://paste2.org/p/2816360
  155. [04:36] <%Nayd> can Prismatic generate any of those?
  156. [04:36] * AlterEgo_Laptop ([email protected]) Quit (Quit: Do fish get thirsty?)
  157. [04:37] <%Nayd> scroll right for spell name
  158. [04:37] <_Zaphod_> it only generates red, blue, and yellowgreen 60s i believe.
  159. [04:38] <_Zaphod_> i made a list of nine of them.
  160. [04:39] <%Nayd> can't that 9 be boosted to 72?
  161. [04:40] <_Zaphod_> only the single +6 and +9 pure color gems have ever been reported.
  162. [04:41] <_Zaphod_> in fact people are saying the yellows don't showup at all.
  163. [04:42] <_Zaphod_> even though the recipe suggest they should.
  164. [04:42] <+KPsN04> WPP: Nay master * r920986c / (3 files in 3 dirs): Fix previous commit. Compiler is a lier - http://git.io/4ECmZA
  165. [04:43] <_Zaphod_> "Cuts a black diamond into a red, blue or yellow gemstone of similar quality. The type of gem is not known until the gem is cut."
  166. [04:44] <_Zaphod_> meaning a red, blue, or yellow item level 60 uncommn.
  167. [04:47] <_Zaphod_> screw it, i'm specialcasing the spell id.
  168. [04:47] <%Nayd> no, wait 1 minute
  169. [04:48] <_Zaphod_> i'll fix it right later. :)
  170. [04:48] <_Zaphod_> it does NOT draw from that full pool of 72 spells.
  171. [04:48] <%Nayd> yeh, got it
  172. [04:49] <_Zaphod_> i've came up with9 that fit the description.